Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preload: fix bug for windows file separators #6968

Merged
merged 2 commits into from
Mar 9, 2020
Merged

preload: fix bug for windows file separators #6968

merged 2 commits into from
Mar 9, 2020

Conversation

priyawadhwa
Copy link

should fix #6944

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #6968 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6968      +/-   ##
==========================================
- Coverage      37%   36.99%   -0.01%     
==========================================
  Files         144      144              
  Lines        9013     9015       +2     
==========================================
  Hits         3335     3335              
- Misses       5256     5258       +2     
  Partials      422      422
Impacted Files Coverage Δ
pkg/minikube/cruntime/docker.go 35.33% <0%> (-0.48%) ⬇️

medyagh
medyagh requested changes Mar 9, 2020
View reviewed changes
pkg/minikube/cruntime/docker.go Outdated Show resolved Hide resolved
@medyagh
Copy link
Member

medyagh commented Mar 9, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 9, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link

All Times minikube: [ 61.485357 62.234412 63.378993]
All Times Minikube (PR 6968): [ 63.399841 62.630348 60.272269]

Average minikube: 62.366254
Average Minikube (PR 6968): 62.100819

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6968) |
+----------------------+-----------+--------------------+
| minikube v           |  0.123214 |           0.123418 |
| Creating kvm2        | 39.842380 |          38.348948 |
| Preparing Kubernetes |  0.718783 |           0.706815 |
| Pulling images       |           |                    |
| Launching Kubernetes | 19.001200 |          19.893059 |
| Waiting for cluster  |  0.064250 |           0.064470 |
+----------------------+-----------+--------------------+

afbjorklund
afbjorklund approved these changes Mar 9, 2020
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 08ae3fc into kubernetes:master Mar 9, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund afbjorklund approved these changes

Assignees

@afbjorklund afbjorklund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. co/preload lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot preload container runtime docker on windows client
6 participants
@priyawadhwa @codecov-io @medyagh @minikube-pr-bot @k8s-ci-robot @afbjorklund